Skip to content

Conversation

@rogercoll
Copy link
Contributor

@rogercoll rogercoll commented Sep 25, 2025

What does this PR do?

Fixes #10020

Upstream fix of Helm Chart uninstallation open-telemetry/opentelemetry-helm-charts#1877

Why is it important?

Any deployment of the kube-stack Helm Chart prior to v0.10.5 version cannot be uninstalled.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@mergify
Copy link
Contributor

mergify bot commented Sep 25, 2025

This pull request does not have a backport label. Could you fix it @rogercoll? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@rogercoll
Copy link
Contributor Author

buildkite test this

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @rogercoll

@rogercoll rogercoll marked this pull request as ready for review October 1, 2025 07:53
@rogercoll rogercoll requested a review from a team as a code owner October 1, 2025 07:53
Copy link
Member

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenruizdegauna rubenruizdegauna enabled auto-merge (squash) October 1, 2025 08:52
@rubenruizdegauna rubenruizdegauna self-requested a review October 1, 2025 09:33
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 1, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@rogercoll rogercoll enabled auto-merge (squash) October 1, 2025 12:50
@rogercoll
Copy link
Contributor Author

buildkite test this

@rogercoll rogercoll merged commit b74a86b into elastic:main Oct 1, 2025
20 of 21 checks passed
@rogercoll rogercoll added the backport-active-all Automated backport with mergify to all the active branches label Oct 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

@Mergifyio backport 8.18 8.19 9.0 9.1 9.2

@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2025

backport 8.18 8.19 9.0 9.1 9.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 6, 2025
* test: remove otel skip statement

* chore: bump kube-stack Helm Chart to 0.9.4

* chore: bump kube-stack to 0.10.4

* chore: bump kube-stack to 0.10.5

---------

Co-authored-by: Ruben Ruiz de Gauna <[email protected]>
(cherry picked from commit b74a86b)
mergify bot pushed a commit that referenced this pull request Oct 6, 2025
* test: remove otel skip statement

* chore: bump kube-stack Helm Chart to 0.9.4

* chore: bump kube-stack to 0.10.4

* chore: bump kube-stack to 0.10.5

---------

Co-authored-by: Ruben Ruiz de Gauna <[email protected]>
(cherry picked from commit b74a86b)
mergify bot pushed a commit that referenced this pull request Oct 6, 2025
* test: remove otel skip statement

* chore: bump kube-stack Helm Chart to 0.9.4

* chore: bump kube-stack to 0.10.4

* chore: bump kube-stack to 0.10.5

---------

Co-authored-by: Ruben Ruiz de Gauna <[email protected]>
(cherry picked from commit b74a86b)
mergify bot pushed a commit that referenced this pull request Oct 6, 2025
* test: remove otel skip statement

* chore: bump kube-stack Helm Chart to 0.9.4

* chore: bump kube-stack to 0.10.4

* chore: bump kube-stack to 0.10.5

---------

Co-authored-by: Ruben Ruiz de Gauna <[email protected]>
(cherry picked from commit b74a86b)
mergify bot pushed a commit that referenced this pull request Oct 6, 2025
* test: remove otel skip statement

* chore: bump kube-stack Helm Chart to 0.9.4

* chore: bump kube-stack to 0.10.4

* chore: bump kube-stack to 0.10.5

---------

Co-authored-by: Ruben Ruiz de Gauna <[email protected]>
(cherry picked from commit b74a86b)
rogercoll added a commit that referenced this pull request Oct 6, 2025
* test: remove otel skip statement

* chore: bump kube-stack Helm Chart to 0.9.4

* chore: bump kube-stack to 0.10.4

* chore: bump kube-stack to 0.10.5

---------


(cherry picked from commit b74a86b)

Co-authored-by: Roger Coll <[email protected]>
Co-authored-by: Ruben Ruiz de Gauna <[email protected]>
rogercoll added a commit that referenced this pull request Oct 7, 2025
* test: remove otel skip statement

* chore: bump kube-stack Helm Chart to 0.9.4

* chore: bump kube-stack to 0.10.4

* chore: bump kube-stack to 0.10.5

---------


(cherry picked from commit b74a86b)

Co-authored-by: Roger Coll <[email protected]>
Co-authored-by: Ruben Ruiz de Gauna <[email protected]>
rogercoll added a commit that referenced this pull request Oct 7, 2025
* test: remove otel skip statement

* chore: bump kube-stack Helm Chart to 0.9.4

* chore: bump kube-stack to 0.10.4

* chore: bump kube-stack to 0.10.5

---------


(cherry picked from commit b74a86b)

Co-authored-by: Roger Coll <[email protected]>
Co-authored-by: Ruben Ruiz de Gauna <[email protected]>
rogercoll added a commit to elastic/kibana that referenced this pull request Oct 7, 2025
## Summary

New kube-stack version that fixes Chart uninstallation for any version
prior 0.10.5:
open-telemetry/opentelemetry-helm-charts#1876

 elastic-agent PR: elastic/elastic-agent#10145

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 7, 2025
## Summary

New kube-stack version that fixes Chart uninstallation for any version
prior 0.10.5:
open-telemetry/opentelemetry-helm-charts#1876

 elastic-agent PR: elastic/elastic-agent#10145

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit e63084b)
ymao1 pushed a commit to ymao1/kibana that referenced this pull request Oct 8, 2025
## Summary

New kube-stack version that fixes Chart uninstallation for any version
prior 0.10.5:
open-telemetry/opentelemetry-helm-charts#1876

 elastic-agent PR: elastic/elastic-agent#10145

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
rogercoll added a commit that referenced this pull request Oct 10, 2025
* test: remove otel skip statement

* chore: bump kube-stack Helm Chart to 0.9.4

* chore: bump kube-stack to 0.10.4

* chore: bump kube-stack to 0.10.5

---------


(cherry picked from commit b74a86b)

Co-authored-by: Roger Coll <[email protected]>
Co-authored-by: Ruben Ruiz de Gauna <[email protected]>
rogercoll added a commit that referenced this pull request Oct 10, 2025
* test: remove otel skip statement (#10145)

* test: remove otel skip statement

* chore: bump kube-stack Helm Chart to 0.9.4

* chore: bump kube-stack to 0.10.4

* chore: bump kube-stack to 0.10.5

---------

Co-authored-by: Ruben Ruiz de Gauna <[email protected]>
(cherry picked from commit b74a86b)

* override upstream k8sattributes configuration

* override logs-only configuration

---------

Co-authored-by: Roger Coll <[email protected]>
Co-authored-by: Ruben Ruiz de Gauna <[email protected]>
rogercoll added a commit to rogercoll/kibana that referenced this pull request Oct 14, 2025
New kube-stack version that fixes Chart uninstallation for any version
prior 0.10.5:
open-telemetry/opentelemetry-helm-charts#1876

 elastic-agent PR: elastic/elastic-agent#10145

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit e63084b)
rylnd pushed a commit to rylnd/kibana that referenced this pull request Oct 17, 2025
## Summary

New kube-stack version that fixes Chart uninstallation for any version
prior 0.10.5:
open-telemetry/opentelemetry-helm-charts#1876

 elastic-agent PR: elastic/elastic-agent#10145

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Oct 27, 2025
## Summary

New kube-stack version that fixes Chart uninstallation for any version
prior 0.10.5:
open-telemetry/opentelemetry-helm-charts#1876

 elastic-agent PR: elastic/elastic-agent#10145

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Flaky Test]: TestOtelKubeStackHelm – test timed out after 2h0m0s

4 participants